Channels
  • Nicholas Culver

    Nicholas Culver

    9 months ago
    Hi everyone, relative Golang beginner here but trying to hack away at https://github.com/infracost/infracost/issues/941. I'm expecting to need some help figuring out where to make all of the updates but I'll post some comments about my progress in the thread to avoid cluttering the channel.
    This is my WIP branch: https://github.com/njculver/infracost/tree/feat/tls-configuration So far I've added flags to
    cmd/infracost/run.go
    , updated the
    Config
    struct in
    internal/config/config.go
    , added an
    []*Config
    to the
    ConfigFileSpec
    struct in
    internal/config/config_file.go
    and I know that
    doRequest
    in
    internal/apiclient/client.go
    is where I need to add in the TLS configuration for the API calls but I think there's some intermediate plumbing that I'm still trying to sort out.
  • Alistair (Infracost)

    Alistair (Infracost)

    9 months ago
    Thanks @Nicholas Culver ūüôĆ . If you add a comment to the GH issue we can assign it to you. What's the reasoning for adding¬†
    []*Config
     to the 
    ConfigFileSpec
     struct?
  • Nicholas Culver

    Nicholas Culver

    9 months ago
    I was thinking that it could be helpful to include the TLS settings into the config file (or part of
    infracost configure
    ) so you could specify them once in a local usage scenario rather than continuously flagging or setting environment variables.