Ali (Infracost)
07/07/2022, 5:49 PMJohannes Grumböck
07/08/2022, 5:23 AM.infracost
folder everywhere it finds terraform code. It’s a little bit tedious to extend all the .gitignore
files - also from other open-source projects, where I not even want to commit/push that change.
Would it be better if infracost would store the “temporary” files in some other shadow tree under $HOME
? Don’t know …
How do others think about it?
Cheers, JoHilton Lem
07/11/2022, 3:21 PMVivian Hunt
07/12/2022, 11:06 AMSawyer Ward
07/12/2022, 10:17 PMSina Bakhtiari
07/30/2022, 6:25 AMBalázs Marján
08/12/2022, 2:06 PMsync-usage-file
option helps them out here by providing a usage file with default values(mostly 0s). Do you see a way this could be improved by somehow providing reasonable defaults, something like the contents of the infracost-usage-example.yml
. Perhaps somehow leveraging that file. Do you see any value here?
2, The user already has their estimate and usage file but they add a new resource that’s type matches an already existing one in the configuration. When using the sync-usage-file
option, could option leverage the already existing usage estimates for the existing resource type for the same type of resource that was just added? Again, do you think there is any value here?
Thanks!Hilton Lem
08/19/2022, 3:05 PMBurak
08/23/2022, 2:17 PMTim (Infracost)
08/30/2022, 1:20 PMTimothy
09/21/2022, 6:51 AMterraform {
required_providers {
confluent = {
source = "confluentinc/confluent"
version = "1.3.0"
}
}
}
I’m a bit rusty with Golang, but if its not too silly, I’m prepared to create a card and have a go with it.Alistair (Infracost)
10/10/2022, 10:48 AMFatih Tokus
10/13/2022, 1:28 PMFatih Tokus
10/13/2022, 1:31 PMFatih Tokus
10/13/2022, 1:31 PM-──────────────────────────────────
-
-The following projects have no cost estimate changes: infracost/infracost/cmd/infracost/testdata/terraform_v0.14_nochange_plan.json
-Run the following command to see their breakdown: infracost breakdown --path=/path/to/code
-
-──────────────────────────────────
-
-
-</details>
-
+💰 Infracost estimate: monthly cost will not change
+<table>
+ <thead>
+ <td>Project</td>
+ <td>Previous</td>
+ <td>New</td>
+ <td>Diff</td>
+ </thead>
+ <tbody>
+ <tr>
+ <td>infracost/infracost/cmd/infraco...aform_v0.14_nochange_plan.json</td>
+ <td align="right">$40.56</td>
+ <td align="right">$40.56</td>
+ <td>$0</td>
+ </tr>
+ </tbody>
+</table>
+
+<details>
+<summary><strong>Infracost output</strong></summary>
+
+```
+──────────────────────────────────
+
+The following projects have no cost estimate changes: infracost/infracost/cmd/infracost/testdata/terraform_v0.14_nochange_plan.json
+Run the following command to see their breakdown: infracost breakdown --path=/path/to/code
+
+──────────────────────────────────
+
+```
+</details>
+
+
--- FAIL: TestOutputFormatGitHubCommentNoChange (0.06s)
--- FAIL: TestOutputFormatGitHubCommentNoChange/HCL (0.06s)Johannes Grumböck
10/14/2022, 8:02 AM❯ INFRACOST_LOG_LEVEL=debug go test -v -cover ./internal/providers/terraform/aws/fsx_windows_file_system_test.go
=== RUN TestFSXWindowsFS
=== PAUSE TestFSXWindowsFS
=== CONT TestFSXWindowsFS
=== RUN TestFSXWindowsFS/HCL
level=warning msg=“Multiple products with prices found for aws_fsx_windows_file_system.my_file_system_ssd SSD storage, using the first product”
testutil.go:202: Unexpected log write. To capture logs remove t.Parallel and use GoldenFileOptions { CaptureLogs = true }: level=warning msg=“Multiple products with prices found for aws_fsx_windows_file_system.my_file_system_ssd SSD storage, using the first product”
level=warning msg=“Multiple products with prices found for aws_fsx_windows_file_system.my_system_ssd SSD storage, using the first product”
testutil.go:202: Unexpected log write. To capture logs remove t.Parallel and use GoldenFileOptions { CaptureLogs = true }: level=warning msg=“Multiple products with prices found for aws_fsx_windows_file_system.my_system_ssd SSD storage, using the first product”
=== RUN TestFSXWindowsFS/Terraform_CLI
level=warning msg=“Multiple products with prices found for aws_fsx_windows_file_system.my_file_system_ssd SSD storage, using the first product”
testutil.go:202: Unexpected log write. To capture logs remove t.Parallel and use GoldenFileOptions { CaptureLogs = true }: level=warning msg=“Multiple products with prices found for aws_fsx_windows_file_system.my_file_system_ssd SSD storage, using the first product”
level=warning msg=“Multiple products with prices found for aws_fsx_windows_file_system.my_system_ssd SSD storage, using the first product”
testutil.go:202: Unexpected log write. To capture logs remove t.Parallel and use GoldenFileOptions { CaptureLogs = true }: level=warning msg=“Multiple products with prices found for aws_fsx_windows_file_system.my_system_ssd SSD storage, using the first product”
--- FAIL: TestFSXWindowsFS (6.62s)
--- FAIL: TestFSXWindowsFS/HCL (0.65s)
--- FAIL: TestFSXWindowsFS/Terraform_CLI (5.97s)
FAIL
coverage: [no statements]
FAIL command-line-arguments 7.180s
FAILWhere would I need to start debugging that? Thanks, Johannes
Rob Houghton
11/13/2022, 11:07 AMRob Houghton
11/16/2022, 1:42 PMJohannes Grumböck
11/25/2022, 10:46 AMHugo (Infracost)
11/25/2022, 10:47 AMHugo (Infracost)
11/25/2022, 10:48 AMHassan (Infracost)
11/25/2022, 10:54 AMJohannes Grumböck
11/25/2022, 7:02 PMDuncan
01/06/2023, 8:52 AMPat Myron
01/24/2023, 12:10 AMRob Houghton
02/06/2023, 1:38 PMfunc getLambdaFunctionRegistryItem() *schema.RegistryItem {
return &schema.RegistryItem{
Name: "aws_lambda_function",
Notes: []string{"Provisioned concurrency is not yet supported."},
ReferenceAttributes: []string{"function_name"},
CoreRFunc: NewLambdaFunction,
}
}
I then added this to a new resource for provisioned concurrency
func getLambdaProvisionedConcurrencyConfigRegistryItem() *schema.RegistryItem {
return &schema.RegistryItem{
Name: "aws_lambda_provisioned_concurrency_config",
RFunc: NewLambdaProvisionedConcurrencyConfig,
ReferenceAttributes: []string{"aws_lambda_function.function_name"},
}
}
Am I missing something ? Because I'm unable to access this from within the new provisioned concurrency resource. It's empty!!
Any help would be appreciated, I looked at the example here
Example terraform below.
# Add example resources for LambdaProvisionedConcurrencyConfig below
resource "aws_lambda_provisioned_concurrency_config" "lambda_provisioned_concurrency_config" {
function_name = aws_lambda_function.lambda.function_name
provisioned_concurrent_executions = 50
qualifier = aws_lambda_function.lambda.version
}
resource "aws_lambda_function" "lambda" {
function_name = "lambda_function_name"
role = "arn:aws:lambda:us-east-1:account-id:resource-id"
handler = "exports.test"
filename = "function.zip"
runtime = "nodejs12.x"
architectures = ["arm64"]
memory_size = 512
}
Ali (Infracost)
02/09/2023, 4:34 PMversion: 0.1
projects:
- path: my-whatif.json
name: development
arm_location: us-east-1
arm_resource_group_name: myRG
# or something like this so the same param names to the ARM CLI can be defined?
arm:
location: us-east-1
resource_group_name: myRG
Johannes Grumböck
03/14/2023, 8:11 AMJesse Cureton
03/28/2023, 12:07 AMazurerm_lb_rule
resource. If the rule is attached to an azurerm_lb
load balancer with the Basic
SKU this is a free resource, but if it’s attached to a Standard
SKU it has an associated cost.
The original issue requesting support for these load balancers called this out, but it looks like it was missed in the the initial implementation. 🧵Jesse Cureton
03/28/2023, 12:07 AMazurerm_lb_rule
resource. If the rule is attached to an azurerm_lb
load balancer with the Basic
SKU this is a free resource, but if it’s attached to a Standard
SKU it has an associated cost.
The original issue requesting support for these load balancers called this out, but it looks like it was missed in the the initial implementation. 🧵lookupParentSku()
helper similar to the lookupRegion helper
2. Set the skuName
field in the ProductFilter for the lb_rule
to match the parent load balancer’s SKU
The piece I’m not familiar with is how to add a new resource price like this to the cloud pricing backend. The dumb answer is to just set the UnitMultiplier for the lb_rule to zero, but I suspect that’s not the correct answer 😁. I’m also not clear how a sometimes-free resource would relate to the “free resources” lists.Tim (Infracost)
03/28/2023, 11:42 AMJesse Cureton
03/28/2023, 12:25 PMTim (Infracost)
03/28/2023, 3:57 PMJesse Cureton
03/28/2023, 6:14 PM