This message was deleted.

yep! looks beautiful

I had to run out, I got up to linux… I can push what I’ve got so far if you want?

up to you if you need my help, there’s one open issue that @broad-addition-19827 started working on and this issue, then we’ll be ready for v0.9 I think (for tmrw)

I’ll finish it up. Take a look at

app_service_certificate_order

,

app_service_custom_hostname_binding

, and

cdn_endpoint

. Those ones are a little odd so I’m not sure if they should use the helper.

app_service_certificate_order

and

app_service_custom_hostname_binding

don’t need the helper (we can just rename the location variable to region).

cdn_endpoint

can use the helper as it then converts the location to a zone. The

return nil

on line 32 can be removed as it can use the default region. Also heads-up that many dns resources were merged to master but only 3 have cost components (

dns_a_record

,

private_dns_zone

and

azurerm_dns_zone

). These 3 can also use the helper as they then convert that region to a “zone”.

what should

nat_gateway

be doing? Right now the cost components ignore the passed in location and use

Region:        strPtr("Global"),

awesome, reviewing/merging/testing now, will take care of nat_gateway too