Howdy,
please add a option so one can disable the ...
# generala
ambitious-shoe-5236
01/31/2023, 4:05 PMHowdy,
please add a option so one can disable the " its the comment useful?" 🙏
w
white-airport-8778
01/31/2023, 4:23 PM
👋 Hi Christoffer, which CI/CD integration are you using? For GH App integration (that’s part of Infracost Cloud), FinOps/DevOps teams can setup guardrails and customize the PR comment so we’d like to collect feedback from their end-users and show the FinOps/DevOps teams the info from their users. But if you’re not using that, I can see how having an option to disable that is handy.
c
cuddly-analyst-30573
02/01/2023, 8:24 PM+1 for having the option; using GitLab. I could create an issue for it if it doesn't already exist.
The message doesn't have too much use if not using Infracost Cloud and its guardrails; would be good to have the option for strictly self-hosted users
cuddly-analyst-30573
02/01/2023, 8:25 PMDoes it make sense for it to never appear if a custom Infracost Pricing API endpoint is set? (Though it might have a default value of IC Cloud's endpoint)
w
white-airport-8778
02/01/2023, 8:31 PM
yeah that could be another way of automating it, but we might as well make it an explicit flag/env so non-self-hosted users can use it too?
Unless the user is using infracost-cloud, the links are anonymous, they just show https://dashboard.infracost.io/feedback
white-airport-8778
02/01/2023, 8:46 PM
I’ll chat with the team and get back to you tmrw!
white-airport-8778
02/02/2023, 4:35 PM
@ambitious-shoe-5236 and @cuddly-analyst-30573 we’ve made a change to disable that link automatically when the CLI is used with a self-hosted Cloud Pricing API. This is the PR you can watch for updates, it’ll go out in the next CLI release, probably in the next week or two 🙂
12 Views