This message was deleted.
# general
b
This message was deleted.
m
Hey rick
I think you might be running into an issue that we just solved this afternoon
s
ah, is there a new docker version?
m
No but I think the example that you followed is incorrect
s
I'll wait it out then, thank you 🙂
m
For the updated example step, note the change directory step
No need to wait you can update your own CI steps with the information contained in that MR
s
Let me check, thank you @mysterious-teacher-68276!
m
I'm ccing @white-airport-8778 who can help you further (im actually away from the laptop at the moment)
w
Hi Rick, I just merged https://gitlab.com/infracost/infracost-gitlab-ci/-/merge_requests/41 - plz ping here if that doesn’t help…
s
I ran the my pipeline twice now, it passes.. says the comment is updated.. but I don't see the comment getting updated
also did a
cat infracost.json
in the pipeline, I see the month difference.
@white-airport-8778 don't have visibility into how the comment is updated.. but its not happening.
w
@sparse-wire-75745 if you add
--behavior=new
to the
infracost comment
command, it posts a new comment each time a commit is pushed to the MR so it makes it easier to debug. If I understand it correctly, Infracost is now posting a comment on the MR, but it shows a 0 diff, and you expected to see a non-0 diff? Does expanding the “Infracost output” section of the MR comment show any diffs of usage-based resources?
s
Hey, I figured the problem
We do a
cd /tmp/base
before we run the
infracost breakdown
but we don't switch back to the previous directory before running
infracost diff
I did a
cd -
and it worked well now
Should I raise an issue for this one? Or can I fix it for you guys?
🙌 1
w
Nice! so we need to update our config-file example to:
Copy code
cd /tmp/base
      infracost breakdown --config-file=${CONFIG_FILE} \
                          --format=json \
                          --out-file=infracost-base.json

    # Generate an Infracost diff and save it to a JSON file.
    - |
      cd -            <<<<<<<< this is what we need to add, correct?
      infracost diff --config-file=${CONFIG_FILE} \
                     --compare-to=/tmp/base/infracost-base.json \
                     --format=json \
                     --out-file=infracost.json
âś… 1
MRs are more than welcome 🙂
s
I will do it, thank you 🙂
w
In the top-level readme for the gitlab-ci repo, can you please also add
--behavior=update
to the infracost-comment command so it’s explicit? That helps users know what to change if
update
isn’t what they want… I think we do that in the config-file example but we forgot to do it in the main example
👍 1
s
sure, I have just request repo access.. I think I need that to be able to raise an MR.
w
you should be able to fork and send a MR from your fork. That’s what previous contributors have done in that repo and other GitHub repos we have
s
let me try that
🙌 1
w
I think https://github.com/infracost/infracost-azure-devops/tree/master/examples/multi-project-config-file might need the same fix, in case you have a little bit more time to contribute. Regardless of that though thanks for helping 🙂 I’ll leave the MRs for Hugo to review tmrw (he’s in the UK timezone so it’s late their time).
@white-airport-8778 I have raised both the PRs, if there's anything else I might have missed please let me know. Thank you for a great product!
🙇 1
🙌 1
the merge checks won't pass from my MR, can they? It needs variables that are specific to your projects.