https://infracost.io logo
Join Slack
Title
#general
Ali (Infracost)

Ali (Infracost)

09/05/2022, 5:13 PM
❓Hey everyone, we’re working on native integration with GitHub using GitHub Apps or OAuth Apps. Do you have a preference on which you need? If so, why?
Johannes Grumböck

Johannes Grumböck

09/05/2022, 7:02 PM
It should be possible to select the repositories the app should have access to, no default access to whole organization.
Ali (Infracost)

Ali (Infracost)

09/05/2022, 7:18 PM
Thanks @Johannes Grumböck - so you’d prefer to select the repos in GH’s UI to give permissions to, then select all of them or a subset in Infracost to enable the integration on, right?
Johannes Grumböck

Johannes Grumböck

09/05/2022, 7:23 PM
Hmm...yes,maybe. Or I'm thinking of something like renovatebot: enabling repos for the app in GH UI, maybe get a PR with some infracost.yml (don't know if needed) ans after merge the integration is enabled?! Just thinking loud while sitting on my sofa 🛋️ 🙃
Ali (Infracost)

Ali (Infracost)

09/05/2022, 7:27 PM
Love a good bit of sofa-based feedback 😄 The alternative flows could be:

Option A: GitHub App

1. GH oauth dance, select All repos or a subset of repos in each org you want to give permissions to. This is all happening in GH’s UI. 2. Then in Infracost Cloud you see the repos that we’re permissioned to see, you can select repos to enable the integration on. 3. We parse HCL and if there are warnings (e.g. we need var files), we show you a link to docs so you can add infracost.yml to repo root and the integration automatically runs again on pushes. 4. PR comments are left automatically with 
behavior=update

Option B: OAuth App

1. GH oauth dance, you just enable an org. So there is no repo-selector in GH’s UI. 2. the rest of the steps are the same.
s

Sylvain Witmeyer

09/05/2022, 7:58 PM
Option A for me because I already know that sharing the full org will be a no go for my company
Ali (Infracost)

Ali (Infracost)

09/05/2022, 8:01 PM
@Sylvain Witmeyer perfect! early feedback saves us rework later on 🙂
Johannes Grumböck

Johannes Grumböck

09/05/2022, 8:45 PM
🅰️ please
Hugo (Infracost)

Hugo (Infracost)

09/06/2022, 8:50 AM
thanks @Sylvain Witmeyer & @Johannes Grumböck for your feedback :infraheart: 💪
o

Ondrej Bilčík

09/06/2022, 12:59 PM
+1, GitHub App makes more sense to me given the Infracost app use case.
i

Ilia lazebnik

09/06/2022, 7:08 PM
+1 Option A
Ali (Infracost)

Ali (Infracost)

09/06/2022, 7:21 PM
Thanks for the quick feedback everyone! The winner was clear: we’re going with Option A
a

Aléxis Mosquera Caicedo

09/08/2022, 10:02 PM
😄 It's later, but yes, Option A.
View count: 3
Join thread in Slack