Title
s
Sina Bakhtiari
05/17/2021, 12:31 PMWhat would be the best way to convert such test case to golden file test?
https://github.com/infracost/infracost/blob/master/internal/providers/terraform/aws/db_instance_test.go#L131
t
Tim (Infracost)
05/17/2021, 12:41 PMAt the risk of being annoying đ: What was your initial thought? (Iâm just noticing you seen to have a lot of ideas and I love that. The more ideas the better).
đartyparrot: 1
đ 1
â¤ď¸ 1
In the spirit of being less annoying: My first reaction would be to âunwind the loopâ so you end up with a tf file a resource for each engine:
resource "aws_db_instance" "aurora" {
engine = "aurora"
instance_class = "db.t3.small"
}
resource "aws_db_instance" "aurora-mysql" {
engine = "aurora-mysql"
instance_class = "db.t3.small"
}
...đ 1
s
Sina Bakhtiari
05/17/2021, 12:49 PMMy initial idea was to have a resource for each of them. I think it won't have a sensible impact on the speed of tests.
đ 1
Seeing this test reminded me of so many conditions that we are probably not handling correctly in the code. Since we do not have a test for all possible permutation of enum configs.
I don't know how but I think we have to think about it some point in the future.
t
Tim (Infracost)
05/17/2021, 12:58 PMYou mean how we have a test for âauroraâ âdb.t3.smallâ, but not one âauroraâ âdb.t3.mediumâ, right? Thatâs interesting,
Seems like it would be nice if we somehow at least had visibility into what permutations weâre not testing.
s
Sina Bakhtiari
05/17/2021, 1:51 PMSorry for late response, yes that's exactly what I mean. There are two kinds of uncovered cases:
1. Simple cases: where there is no special logic involved and we can just be sure about the pricing API coverage
2. Complex cases: These are where we have if, select statements and ... for instance when the field
AXBZđ 1
t
Tim (Infracost)
05/17/2021, 2:33 PMWhatâs a concrete example of #2?
s
Sina Bakhtiari
05/17/2021, 3:07 PMTake https://github.com/infracost/infracost/blob/master/internal/providers/terraform/google/storage_bucket.go#L48 as an eaxmple:
resourceGroupstorageClassresourceGrouplocationresourceGroupt
Tim (Infracost)
05/17/2021, 3:23 PMOk yeah I see what you mean.
a
Ali (Infracost)
05/17/2021, 10:12 PMDoes the https://fuzzbuzz.io/what-is-fuzz-testing/ > âCoverage Guided Fuzzingâ seem interesting? If so, let me know if youâd like me to arrange a quick demo call with them this Wed/Thu, I know the foundersâŚ
s
Sina Bakhtiari
05/18/2021, 7:27 PMThat would probably cover some areas but I'm not sure if that could be the best strategy. I think we have to think more about the possible solutions.