#contributors - Looking at this test failure a

$https://infracost.io logo$

Home Docs

Join the conversation Join Slack

Channels

# contributors

# general

Channels

$Ali (Infracost)$

Ali (Infracost)

8 months ago

Looking at this test failure after I merged a PR into the master branch:

=== CONT  TestComputeInstance
    testutil.go:195: 
        Output does not match golden file: 
        
        --- Expected
        +++ Actual
        @@ -20,3 +20,3 @@
          ├─ Standard provisioned storage (pd-standard)                         10  GiB           $0.40 
        - └─ NVIDIA Tesla K80 (preemptible)                                  2,920  hours       $394.20 
        + └─ NVIDIA Tesla K80 (preemptible)                                  2,920  hours       $109.50 
                                                                                                        
        @@ -35,2 +35,2 @@
                                                                                                        
        - OVERALL TOTAL                                                                       $1,923.12 
        + OVERALL TOTAL                                                                       $1,638.42

$Alistair (Infracost)$
Alistair (Infracost)
8 months ago
I had to fix those recently: https://github.com/infracost/infracost/pull/1032/commits/88da5272b3f12a984afb8811bf933da02ff57ae9 So might be something with that and Google changing the mappings.
$Ali (Infracost)$
Ali (Infracost)
8 months ago
Thanks, yep the footnote on this page confirms it:
```
*Spot price is the current price which applies to Spot VMs and also preemptible VMs.
```
$Alistair (Infracost)$
Alistair (Infracost)
8 months ago
Did you find the fix for this? If not I can have a look
$Ali (Infracost)$
Ali (Infracost)
8 months ago
I thought your commit fixed it as in the
```
feat/s3-estimation
```
branch,
```
infracost breakdown --path internal/providers/terraform/google/testdata/compute_instance_test --fields all
```
shows correct prices/costs for the K80 lines
$Alistair (Infracost)$
Alistair (Infracost)
8 months ago
Hmm let me check, that commit got merged a few days ago so is in master as well
$Ali (Infracost)$
Ali (Infracost)
8 months ago
sorry, I should have said: the latest release shows the correct prices/costs (ignore your branch part of my comment)
$Alistair (Infracost)$
Alistair (Infracost)
8 months ago
Cool, yeah looks like the price changed and the test needs updated. Will push the test fix to master.

Join thread in Slack

View count: 4