Hey everyone does anyone have any issues with MR comments no Infracost Community #general

$https://infracost.io logo$

Hey everyone, does anyone have any issues with MR ...

brave-dinner-47346

02/25/2022, 3:09 PM

Hey everyone, does anyone have any issues with MR comments not updating? My pipeline keeps creating new comments despite passing the update bahavior perimeter. Ive tried changing the tagging as well from the default. This is my current gitlab-ci command:

Copy code

- infracost comment gitlab
      --gitlab-server-url $CI_SERVER_URL
      --gitlab-token $GITLAB_TOKEN
      --path infracost.json
      --repo $CI_PROJECT_PATH
      --merge-request $CI_MERGE_REQUEST_IID
      --behavior update

Logs:
time="2022-02-25T14:44:44Z" level=info msg="Finding matching comments for tag infracost-comment"
time="2022-02-25T14:44:44Z" level=info msg="Found 0 matching comments"
time="2022-02-25T14:44:44Z" level=info msg="Creating new comment"

busy-agent-35515

02/25/2022, 3:31 PM

Hey Bryce! Interesting 🤔

busy-agent-35515

02/25/2022, 3:35 PM

Can you see the text of the existing comments? At the very top they should have

[//]: <> (infracost-comment)

markdown comment. That's how we track them. It should be visible in comment's editor

brave-dinner-47346

02/25/2022, 3:42 PM

message has been deleted

brave-dinner-47346

02/25/2022, 3:43 PM

Copy code

[//]: <> (infracost)

💰 Infracost estimate: **monthly cost will not change**
<table>
  <thead>
    <td>Project</td>
    <td>Previous</td>
    <td>New</td>
    <td>Diff</td>
  </thead>
  <tbody>
    <tr>
      <td>mmsys/fed/EMR/terraform/test.json</td>
      <td align="right">$0</td>
      <td align="right">$0</td>
      <td>$0</td>
    </tr>
  </tbody>
</table>

<details>
<summary><strong>Infracost output</strong></summary>

busy-agent-35515

02/25/2022, 3:44 PM

Hm, okay. So this comment has the tag

infracost

. If you use the CI command without the

--tag infracost

flag, it will start searching for

infracost-comment

. So this one won't be matched.

busy-agent-35515

02/25/2022, 3:44 PM

Are there other comments?

brave-dinner-47346

02/25/2022, 3:47 PM

So I am trying this locally as well:

Copy code

[//]: <> (infracost-comment)

💰 Infracost estimate: **monthly cost will not change**
<table>
  <thead>
    <td>Project</td>
    <td>Previous</td>
    <td>New</td>
    <td>Diff</td>
  </thead>
  <tbody>
    <tr>
      <td>mmsys/fed/EMR/terraform/mmsys-preprod-plan.out.json</td>
      <td align="right">$0</td>
      <td align="right">$0</td>
      <td>$0</td>
    </tr>
  </tbody>
</table>

<details>
<summary><strong>Infracost output</strong></summary>

brave-dinner-47346

02/25/2022, 3:47 PM

this comes from

brave-dinner-47346

02/25/2022, 3:48 PM

Copy code

infracost comment gitlab \ 
--gitlab-server-url <https://gitlab.com> \
--repo mmsys/fed/EMR \
--merge-request 10 \
--tag GITLAB_TOKEN_FED_EMR \
--path infracost.json \
--behavior update \
--gitlab-token $TOKEN \
--log-level debug

brave-dinner-47346

02/25/2022, 3:48 PM

if I run this again I still see

Copy code

time="2022-02-25T16:46:45+01:00" level=info msg="Finding matching comments for tag GITLAB_TOKEN_FED_EMR"
time="2022-02-25T16:46:45+01:00" level=info msg="Found 0 matching comments"
time="2022-02-25T16:46:45+01:00" level=info msg="Creating new comment"

busy-agent-35515

02/25/2022, 3:49 PM

GITLAB_TOKEN_FED_EMR

and env var or a tag value?

brave-dinner-47346

02/25/2022, 3:50 PM

no its just a string

brave-dinner-47346

02/25/2022, 3:50 PM

for testing purposes

busy-agent-35515

02/25/2022, 3:51 PM

From the command it will be treated as a string, and if there are no any other comments with

GITLAB_TOKEN_FED_EMR

in them, it won't match. Could you please change your TF file and push it again? Currently I'm seeing you using 3 different tags (default one,

infracost

and

GITLAB_TOKEN_FED_EMR

)

busy-agent-35515

02/25/2022, 3:52 PM

As you already have one comment with

infracost

tag, could you try to use

--tag infracost

busy-agent-35515

02/25/2022, 3:53 PM

BTW, I just tested the command on our demo app, it worked as expected. Although it's not a self-hosted version https://gitlab.com/infracost/gitlab-ci-demo/-/merge_requests/26#note_855633119

brave-dinner-47346

02/25/2022, 3:55 PM

Well, I've been cleaning up the multiple comments 😆 and trying to experiment locally which is where the other tags came from

🙂 1

brave-dinner-47346

02/25/2022, 3:56 PM

I will try another build with the following commands:

Copy code

- infracost breakdown --sync-usage-file
      --usage-file infracost-usage.yml
      --format json --path ${PLAN}.json
      --out-file infracost.json

    - infracost comment gitlab
      --gitlab-server-url $CI_SERVER_URL
      --gitlab-token $GITLAB_TOKEN
      --path infracost.json
      --tag infracost
      --repo $CI_PROJECT_PATH
      --merge-request $CI_MERGE_REQUEST_IID
      --behavior update

🤞 1

brave-dinner-47346

02/25/2022, 3:57 PM

creating a comment

Copy code

[//]: <> (infracost)

💰 Infracost estimate: **monthly cost will not change**
<table>
  <thead>
    <td>Project</td>
    <td>Previous</td>
    <td>New</td>
    <td>Diff</td>
  </thead>
  <tbody>
    <tr>
      <td>mmsys/fed/EMR/terraform/mmsys-preprod-plan.out.json</td>
      <td align="right">$0</td>
      <td align="right">$0</td>
      <td>$0</td>
    </tr>
  </tbody>
</table>

<details>
<summary><strong>Infracost output</strong></summary>

busy-agent-35515

02/25/2022, 3:58 PM

Okay, looks correct. Let's change a TF file and re-run the comment command 🙂

brave-dinner-47346

02/25/2022, 3:58 PM

sure

busy-agent-35515

02/25/2022, 3:59 PM

FYI if there are no any changes in the output, the command won't post anything

brave-dinner-47346

02/25/2022, 4:02 PM

Just changing some s3 bucket names...

Copy code

$ infracost comment gitlab --gitlab-server-url $CI_SERVER_URL --gitlab-token $GITLAB_TOKEN --path infracost.json --tag infracost --repo $CI_PROJECT_PATH --merge-request $CI_MERGE_REQUEST_IID --behavior update
time="2022-02-25T16:01:40Z" level=info msg="Finding matching comments for tag infracost"
time="2022-02-25T16:01:41Z" level=info msg="Found 0 matching comments"
time="2022-02-25T16:01:41Z" level=info msg="Creating new comment"

brave-dinner-47346

02/25/2022, 4:02 PM

message has been deleted

busy-agent-35515

02/25/2022, 4:03 PM

Seems like a bug. Do both comments have the

infracost

tag?

brave-dinner-47346

02/25/2022, 4:04 PM

yah, its the same build same commands adjusting some bucket names in the terraform code

brave-dinner-47346

02/25/2022, 4:04 PM

Copy code

image:
    name: infracost/infracost:ci-0.9

brave-dinner-47346

02/25/2022, 4:06 PM

full comment, if it helps

Copy code

[//]: <> (infracost)

💰 Infracost estimate: **monthly cost will not change**
<table>
  <thead>
    <td>Project</td>
    <td>Previous</td>
    <td>New</td>
    <td>Diff</td>
  </thead>
  <tbody>
    <tr>
      <td>mmsys/fed/EMR/terraform/mmsys-preprod-plan.out.json</td>
      <td align="right">$0</td>
      <td align="right">$0</td>
      <td>$0</td>
    </tr>
  </tbody>
</table>

<details>
<summary><strong>Infracost output</strong></summary>

Project: mmsys/fed/EMR/terraform/mmsys-preprod-plan.out.json + module.s3_log_storage.aws_s3_bucket.default[0] Monthly cost depends on usage + Standard + Storage Monthly cost depends on usage +$0.0245 per GB + PUT, COPY, POST, LIST requests Monthly cost depends on usage +$0.0054 per 1k requests + GET, SELECT, and all other requests Monthly cost depends on usage +$0.00043 per 1k requests + Select data scanned Monthly cost depends on usage +$0.00225 per GB + Select data returned Monthly cost depends on usage +$0.0008 per GB + Standard - infrequent access + Storage Monthly cost depends on usage +$0.0135 per GB + PUT, COPY, POST, LIST requests Monthly cost depends on usage +$0.01 per 1k requests + GET, SELECT, and all other requests Monthly cost depends on usage +$0.001 per 1k requests + Retrievals Monthly cost depends on usage +$0.01 per GB + Select data scanned Monthly cost depends on usage +$0.00225 per GB + Select data returned Monthly cost depends on usage +$0.01 per GB + Glacier flexible retrieval + Storage Monthly cost depends on usage +$0.00405 per GB + PUT, COPY, POST, LIST requests Monthly cost depends on usage +$0.036 per 1k requests + GET, SELECT, and all other requests Monthly cost depends on usage +$0.00043 per 1k requests + Retrieval requests (standard) Monthly cost depends on usage +$0.036 per 1k requests + Retrievals (standard) Monthly cost depends on usage +$0.012 per GB + Select data scanned (standard) Monthly cost depends on usage +$0.0096 per GB + Select data returned (standard) Monthly cost depends on usage +$0.012 per GB + Retrieval requests (expedited) Monthly cost depends on usage +$12.00 per 1k requests + Retrievals (expedited) Monthly cost depends on usage +$0.036 per GB + Select data scanned (expedited) Monthly cost depends on usage +$0.024 per GB + Select data returned (expedited) Monthly cost depends on usage +$0.036 per GB + Select data scanned (bulk) Monthly cost depends on usage +$0.0012 per GB + Select data returned (bulk) Monthly cost depends on usage +$0.003 per GB + Early delete (within 90 days) Monthly cost depends on usage +$0.00405 per GB Monthly cost change for mmsys/fed/EMR/terraform/mmsys-preprod-plan.out.json Amount: $0.00 ($0.00 → $0.00) ────────────────────────────────── Key: ~ changed, + added, - removed 37 cloud resources were detected: ∙ 1 was estimated, 1 includes usage-based costs, see https://infracost.io/usage-file ∙ 1 wasn't estimated, report it in https://github.com/infracost/infracost: ∙ 1 x aws_emr_cluster ∙ 35 were free: ∙ 8 x aws_security_group_rule ∙ 5 x aws_security_group ∙ 3 x aws_iam_role ∙ 3 x aws_iam_role_policy_attachment ∙ 2 x aws_network_acl ∙ 2 x aws_route_table ∙ 2 x aws_route_table_association ∙ 2 x aws_subnet ∙ 1 x aws_default_security_group ∙ 1 x aws_iam_instance_profile ∙ 1 x aws_internet_gateway ∙ 1 x aws_key_pair ∙ 1 x aws_route ∙ 1 x aws_s3_bucket_public_access_block ∙ 1 x aws_vpc ∙ 1 x aws_vpc_endpoint

Copy code

</details>

This comment will be updated when the cost estimate changes.

<sub>
  Is this comment useful? <a href="<https://www.infracost.io/feedback/submit/?value=yes>" rel="noopener noreferrer" target="_blank">Yes</a>, <a href="<https://www.infracost.io/feedback/submit/?value=no>" rel="noopener noreferrer" target="_blank">No</a>
</sub>

busy-agent-35515

02/25/2022, 4:11 PM

Thank you very much for helping with the debug! May I ask what version of GitLab you're using? Is it Enterprise Edition?

brave-dinner-47346

02/25/2022, 4:13 PM

Copy code

GitLab Enterprise Edition 13.12.9-ee

busy-agent-35515

02/25/2022, 4:13 PM

We are using GitLab GraphQL API to fetch the MR comments. It works with the cloud version as I mentioned above, so I assume there might be something up with EE's API.

brave-dinner-47346

02/25/2022, 4:14 PM

the big sad 😭, in the meanwhile maybe I can post to slack or so instead

busy-agent-35515

02/25/2022, 4:17 PM

We always want to know more how our users use Infracost. May I ask how often do you push to the same MR and are the new comments too noisy for you?

busy-agent-35515

02/25/2022, 4:19 PM

If you have couple more minutes, maybe you'd be able to run a curl command to the API? Maybe we can see what it returns and pinpoint the issue

busy-agent-35515

02/25/2022, 4:25 PM

Also, maybe you know the API scope of the access token? It should be

api

for read and write requests

brave-dinner-47346

02/25/2022, 4:26 PM

This is a new project to move to gitlab from some legacy stuff, it will be used quite heavily in the future. I guess merge request can get quite noisy if it post a comment every commit push

brave-dinner-47346

02/25/2022, 4:27 PM

the token is read/write for the repo and has full api access

👍 1

brave-dinner-47346

02/25/2022, 4:27 PM

I can maybe test a curl command or two 😎

busy-agent-35515

02/25/2022, 4:28 PM

Haha, nice. Thank you 🙏 Let me prepare it and I'll get back to you asap.

brave-dinner-47346

02/25/2022, 4:28 PM

sure

busy-agent-35515

02/25/2022, 5:43 PM

Sorry for the delay. Here's the command

Copy code

curl -X POST \
-H "Authorization: Bearer $GITLAB_TOKEN" \
-H "Content-Type: application/json" \
-d '{"query": "{project(fullPath: \"mmsys/fed/EMR\") {mergeRequest(iid: \"10\") {notes { nodes {id url createdAt body}}}}}"}' \
$CI_SERVER_URL

I think you just need to have the token and the url env vars set up and it should work. Well, we'll see 😄

brave-dinner-47346

02/28/2022, 1:27 PM

with that curl I am unfortunately getting a 404 return 😞

brave-dinner-47346

02/28/2022, 1:27 PM

<title>The page you're looking for could not be found (404)</title>

busy-agent-35515

02/28/2022, 1:32 PM

hey Bryce. My bad, the url should be

$CI_SERVER_URL/api/graphql

if it's the same as for the gitlab.com. Could you please try again?

brave-dinner-47346

02/28/2022, 1:34 PM

Copy code

{"data":{"project":null}}%

busy-agent-35515

02/28/2022, 1:40 PM

Okay, this response can explain the 0 matching comments. Now need to figure out how to actually get something back

busy-agent-35515

02/28/2022, 1:46 PM

Will try to replicate same structure of the project with community edition, will see if it works there. Thanks for running the requests.

👍 1

busy-agent-35515

03/01/2022, 11:07 AM

Hey Bryce! May I ask you how is the repo name formed? GitLab cloud/CE doesn't allow to use slashes in the name, and your full path has two. I suspect this may be an issue for the GraphQL API. However I'm confused as it worked for posting the comment apparently (we use REST API for posting). I've tried the curl request on an local CE server and that's how the result looks like for no results:

Copy code

{"data":{"project":{"mergeRequest":{"notes":{"nodes":[]}}}}}%

and with one comment returned:

Copy code

{"data":{"project":{"mergeRequest":{"notes":{"nodes":[{"id":"<gid://gitlab/Note/1>","url":"<http://gitlab.example.com/root/terraform-test/-/merge_requests/1#note_1>","createdAt":"2022-03-01T11:04:04Z","body":"foobar"}]}}}}}%

brave-dinner-47346

03/01/2022, 11:59 AM

Copy code

.com/mmsys/fed/EMR

brave-dinner-47346

03/01/2022, 12:00 PM

mr url

com/mmsys/fed/EMR/-/merge_requests/10

busy-agent-35515

03/01/2022, 12:26 PM

mmsys

the org and

fed/EMR

a project name? Or

mmsys/fed

and

EMR

? Sorry, I don't have much experience with GitLab, so trying to understand where to investigate next 🙂

brave-dinner-47346

03/01/2022, 1:28 PM

mmsys is the parent group, then a sub group of FED

👍 1

brave-dinner-47346

03/01/2022, 1:28 PM

EMR is the repo name

👍 1

busy-agent-35515

03/01/2022, 4:29 PM

Reproduced the issue with replicated group/subgroup/repo project. First, I saw the same response you receive and thought something's wrong with the API. I tried

Project Access Tokens

with api or all scopes. Then I switched the test repo to be public and the curl request started to return proper data. And then I use

Personal Access Token

with api scope and private repo - it also worked. Here's the response

Copy code

{"data":{"project":{"mergeRequest":{"notes":{"nodes":[{"id":"<gid://gitlab/Note/2>","url":"<http://gitlab.example.com/mssys/fed/emr/-/merge_requests/1#note_2>","createdAt":"2022-03-01T16:22:55Z","body":"foobar"}]}}}}}%

The

infracost comment

command also worked with that access token. Could you please double check what kind of token do you use?

brave-dinner-47346

03/02/2022, 10:01 AM

I was using a Repo user access token, but I can try with a personal token to verify

🙌 1

brave-dinner-47346

03/02/2022, 10:15 AM

Yah, so that works with my user access token in the ci/cd as well as locally. Strange

👍 1

brave-dinner-47346

03/02/2022, 10:16 AM

I'll see if i can get an application user to set this up without my personal user

busy-agent-35515

03/02/2022, 10:16 AM

I still don't know the reason why it's happening, but I hope it unblocks your work. If I find anything about it, I'll let you know. We also need to mention this case in our documentation's troubleshooting guide.

brave-dinner-47346

03/02/2022, 10:18 AM

its easier to get an application user regardless as gitlab doesnt seem to offer group level access tokens, only repo specific access tokens for api access

busy-agent-35515

03/02/2022, 10:20 AM

True, but it's still strange that the repo token doesn't have access to the repo in GraphQL, but REST API works fine. Might be a bug on GitLab side

brave-dinner-47346

03/02/2022, 10:30 AM

oh fake news, gitlab includes group level tokens in 14.7

busy-agent-35515

03/02/2022, 10:31 AM

But do they work for your repo? 🙂

brave-dinner-47346

03/02/2022, 10:39 AM

well I guess ill learn that when we upgrade our gitlab server

🤞 1

brave-dinner-47346

03/02/2022, 10:39 AM

could also be a bug with my specific gitlab version

busy-agent-35515

03/02/2022, 10:45 AM

How do you see the update comment feature? Does it work as you expect?

brave-dinner-47346

03/02/2022, 10:47 AM

Yah, aside from using my personal token 😛

🙂 1

7 Views

Open in Slack

Previous Next